Add S390x CI Build Status Badge to README #12044
Conversation
Firoj-Patel
force-pushed
the
s390x-CI-tag
branch
from
468441d to
8fe17b6
Compare
This commit adds the appropriate tag to support the newly migrated Continuous Integration (CI) pipeline for the s390x architecture on Jenkins. Signed-off-by: Firoj-IBM <[email protected]>
Firoj-Patel
force-pushed
the
s390x-CI-tag
branch
from
8fe17b6 to
625f82d
Compare
README.md
Outdated
| [](http://www.apache.org/licenses/LICENSE-2.0) | ||
| [](https://twitter.com/strimziio) | ||
| [](https://artifacthub.io/packages/search?repo=strimzi-kafka-operator) | ||
| [](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/) |
There was a problem hiding this comment.
As triaged on the last community call we would like to have a dedicated section in the README with budges coming from the community and not together with the official ones.
You should create a new section at the bottom of this README with this new badge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12044 +/- ##
============================================
- Coverage 74.91% 74.78% -0.14%
- Complexity 6454 6615 +161
============================================
Files 343 376 +33
Lines 24336 25325 +989
Branches 3207 3389 +182
============================================
+ Hits 18232 18940 +708
- Misses 4830 4999 +169
- Partials 1274 1386 +112 🚀 New features to boost your workflow:
|
Signed-off-by: Firoj-IBM <[email protected]>
README.md
Outdated
| ### Architecture support | ||
| #### Linux on IBM Z (s390x) : | ||
| [](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/) |
There was a problem hiding this comment.
I think this looks good. Just a it about the formatting and fixing the header levels to not have it folded under the SBOM chapter.
| ### Architecture support | |
| #### Linux on IBM Z (s390x) : | |
| [](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/) | |
| ## Architecture support | |
| ### Linux on IBM Z (s390x) : | |
| [](https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/) |
There was a problem hiding this comment.
Hi,
Would it be appropriate to insert this section right after the License chapter in the README? I'd like to confirm before updating the file. Thanks.
|
I think the current position is fine. But I agree with the suggestions by Jakub. |
Signed-off-by: Firoj-IBM <[email protected]>
|
Updated file per Jakub’s suggestions. |
There was a problem hiding this comment.
It would be fine with me if it moves right after the license section. But I can speak only for my self. Not sure about the others. In any case the PR looks good also as it is right now.
@katheris @im-konge @Frawless I think you were part of the dicussion on the triage call ... can you have a look as well?
Signed-off-by: Firoj-IBM <[email protected]>
|
@scholzj Moved the block below the Licence section to improve structure. |
5 participants
Type of change
Description
As per the discussion thread here, we have now setup the CI for s390x at https://ibmz-ci.osuosl.org/job/Strimzi_Kafka_Operator_IBMZ_CI/ and would like to add a build status badge in the README.md file.
The badge provides a visual indicator of the latest build status (e.g., passing, failing, or in progress) from the S390x Jenkins pipeline.
Checklist
Please go through this checklist and make sure all applicable tasks have been done